fix: remove stale slicing type ignore - #462
Open
mkg0908 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 29 29
Lines 2446 2446
Branches 464 464
=======================================
Hits 2422 2422
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiki-tempula
approved these changes
Jun 3, 2026
Collaborator
|
Would it be better if you could fix the other mypy and ruff issue, please? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type: ignore[misc]suppression fromslicing()Tests
.venv/bin/mypy src/alchemlyb/preprocessing/subsampling.py --ignore-missing-imports --disable-error-code no-any-return.venv/bin/python -m compileall -q src/alchemlyb/preprocessing/subsampling.pygit diff --checkCloses #460